Core: Correctly ignore late tests after a nested QUnit.module.only() …

…closure Fixes #1645. Closes #1658.
qunitjs · Sep 18, 2021 · e0aa69a · e0aa69a
1 parent f30d5de
commit e0aa69a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/module.js b/src/module.js
@@ -136,11 +136,13 @@ module.only = function( ...args ) {
 	if ( !focused ) {
 		config.modules.length = 0;
 		config.queue.length = 0;
-	}
 
-	processModule( ...args );
+		// aggressively ignore any direct tests in "outer" nested modules
+		config.currentModule.ignored = true;
+	}
 
 	focused = true;
+	processModule( ...args );
 };
 
 module.skip = function( name, options, executeNow ) {

diff --git a/test/cli/fixtures/only/module.js b/test/cli/fixtures/only/module.js
@@ -26,6 +26,10 @@ QUnit.module( "module B", function() {
 		} );
 	} );
 
+	QUnit.test( "test with the only-module as its peer", function( assert ) {
+		assert.true( false, "this test should not run" );
+	} );
+
 	QUnit.module( "This also should not run", function() {
 		QUnit.test( "normal test", function( assert ) {
 			assert.true( false, "this test should not run" );