Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JIB custom entrypoint examples on documentation #27584

Merged
merged 1 commit into from Aug 30, 2022
Merged

Add JIB custom entrypoint examples on documentation #27584

merged 1 commit into from Aug 30, 2022

Conversation

schmittjoaopedro
Copy link
Contributor

This PR regards the improvement raised at #27575

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Aug 30, 2022
@schmittjoaopedro schmittjoaopedro changed the title add JIB custom entrypoint examples on documentation Add JIB custom entrypoint examples on documentation Aug 30, 2022
gsmet
gsmet previously requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will let @geoand have a look at this one. Just let's make sure we don't keep the merge commit in the PR before merging.

Quarkus Documentation automation moved this from To do to Review pending Aug 30, 2022
@gsmet gsmet requested a review from geoand August 30, 2022 09:01
geoand
geoand reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot!

I added one comment.
Also, please rebase the PR onto the latest main as @gsmet suggests

docs/src/main/asciidoc/container-image.adoc Show resolved Hide resolved
@schmittjoaopedro schmittjoaopedro force-pushed the improve-jib-custom-entrypoint-documentation branch from a04ef49 to bea2fdb Compare August 30, 2022 10:14
@geoand
Copy link
Contributor

geoand commented Aug 30, 2022

One last thing, can you please squash the commits?

@schmittjoaopedro schmittjoaopedro force-pushed the improve-jib-custom-entrypoint-documentation branch from bea2fdb to f6d4b05 Compare August 30, 2022 12:57
@schmittjoaopedro
Copy link
Contributor Author

One last thing, can you please squash the commits?

Done!

geoand
geoand approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand dismissed gsmet’s stale review August 30, 2022 13:01

issue addressed

Quarkus Documentation automation moved this from Review pending to Reviewer approved Aug 30, 2022
@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Aug 30, 2022
@gastaldi gastaldi linked an issue Aug 30, 2022 that may be closed by this pull request
Improve custom entrypoint configuration documentation for JIB images #27575
Closed
@gastaldi gastaldi merged commit 0283b7d into quarkusio:main Aug 30, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Aug 30, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 30, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Done
Milestone
2.12.1.Final
Development

Successfully merging this pull request may close these issues.

Improve custom entrypoint configuration documentation for JIB images
4 participants
@schmittjoaopedro @geoand @gsmet @gastaldi