Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom entrypoint configuration documentation for JIB images #27575

Closed
schmittjoaopedro opened this issue Aug 29, 2022 · 3 comments · Fixed by #27584
Closed

Improve custom entrypoint configuration documentation for JIB images #27575

schmittjoaopedro opened this issue Aug 29, 2022 · 3 comments · Fixed by #27584

Comments

@schmittjoaopedro
Copy link
Contributor

schmittjoaopedro commented Aug 29, 2022

Description

By looking at the JIB's documentation on configuring custom entry points JIB Docs there is not enough information on the different ways you can configure custom startup scripts for ubi8/openjdk-11-runtime or ubi8/openjdk-17-runtime images, I mean it´s quite challenging to find the right way to set the values to customize the entry point.

Implementation ideas

For example, the documentation could be improved to provide two ways of configuring it:

  1. Configuring an in-line entry point start-up command in the application.properties file:
quarkus.jib.jvm-entrypoint=java,-agentlib:jdwp=transport=dt_socket\\,server=y\\,suspend=n\\,address=*:5005,-jar,quarkus-run.jar
  1. Creating a custom startup file at src/main/jib/jboss/home/run-java.sh with some content like below:
java \
  -Djavax.net.ssl.trustStore=/deployments/truststore \
  -Djavax.net.ssl.trustStorePassword=$TRUST_STORE_PASSWORD \
  -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 \
  -jar quarkus-run.jar

and providing the custom jvm-entrypoint configuration quarkus.jib.jvm-entrypoint=/bin/sh,run-java.sh

@schmittjoaopedro schmittjoaopedro added the kind/enhancement New feature or request label Aug 29, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2022

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Aug 30, 2022

@schmittjoaopedro would you like to contribute the docs improvement you have in mind? This is the doc that would need to be updated

@schmittjoaopedro
Copy link
Contributor Author

Hi @geoand , of course, I'll create a PR for it.

@gastaldi gastaldi linked a pull request Aug 30, 2022 that will close this issue
Quarkus Documentation automation moved this from To do to Done Aug 30, 2022
@gsmet gsmet added this to the 2.12.1.Final milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants