Bump to Vert.x 4.3.1 and Netty 4.1.78 #26294
Conversation
quarkus-bot
bot
added
area/dependencies
cescoffier
force-pushed
the
vertx-4.3.1-take-2
branch
from
55d8f18
to
721f8c2
Compare
This comment has been minimized.
This comment has been minimized.
cescoffier
force-pushed
the
vertx-4.3.1-take-2
branch
from
721f8c2
to
b5b3c55
Compare
This comment has been minimized.
This comment has been minimized.
This new combination is tricky. It imposes to have brotli4j available in the classpath as, because of the new HTTP compression feature from vert.x, it does now have a hard dependency on brotli4j. While in JVM mode, everything is fine, native compilation fails if not there. We have tried a few things to avoid the dependency, but we are hitting oracle/graal#4652.
…ending a HTTP request with a body. Why ? Because it's the spec: http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.3
cescoffier
force-pushed
the
vertx-4.3.1-take-2
branch
from
b5b3c55
to
51d773f
Compare
|
On the current |
|
@cescoffier great to hear :) and no concerns, it all seems under control 💯 |
|
@cescoffier regarding brotli: I'm aware of that graalvm limitation as I've hit similar issues in the past; FYI there are possible workarounds but aren't "pretty". I'd say it's totally fine to have the dependency around - or does it cause any particular issue (other than the extra disk space) ? |
|
@Sanne yes, that's the only issue. It even gets eliminated during the native compilation. |
Two days ago Vert.X were [bumped to 4.3.1](quarkusio/quarkus#26294) that caused errors in CI daily runs. According to the [4.3 release notes](https://vertx.io/blog/whats-new-in-vert-x-4-3/#vertx-web) the handler order matters, I also found similar issue [reported here](vert-x3/vertx-web#2182]. Security policy handler `CorsHandler` should be registered after the logging handler.
|
Hello @cescoffier , upgrade from Vert.X 4.2.7 to 4.3.1 also bring some important changes (f.e. Vet.X Web handlers order is now validated), please see 4.3 release notes. Could you please add "noteworthy" label and add details about the change to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.11 ? |
This new combination is tricky. It imposes to have brotli4j available in the classpath as, because of the new HTTP compression feature from vert.x, it does now have a hard dependency on brotli4j. While in JVM mode, everything is fine, native compilation fails if not there. We have tried a few things to avoid the dependency, but we are hitting oracle/graal#4652.