Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures - correct Vert.X Web handler order #738

Merged
merged 1 commit into from Jun 27, 2022
Merged

Fix CI failures - correct Vert.X Web handler order #738

merged 1 commit into from Jun 27, 2022

Conversation

michalvavrik
Copy link
Contributor

@michalvavrik michalvavrik commented Jun 27, 2022 •
edited

Summary

Two days ago Vert.X were bumped to 4.3.1 that caused errors in CI daily runs. According to the 4.3 release notes the handler order matters, I also found similar issue reported here. Security policy handler CorsHandler should be registered after the logging handler.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Fix CI failures - correct Vert.X Web handler order
ce41ae0 
Two days ago Vert.X were bumped to 4.3.1 that caused errors in CI daily runs. According to the 4.3 release notes the handler order matters, I also found similar issue reported here. Security policy handler CorsHandler should be registered after the logging handler.
@michalvavrik michalvavrik requested a review from pjgg June 27, 2022 12:21
pjgg
pjgg approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit cecc1b5 into quarkus-qe:main Jun 27, 2022
@michalvavrik michalvavrik deleted the feature/fix-vertx-web-handler-order branch June 27, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalvavrik @pjgg