Re-create Elasticsearch schema on startup in tests/dev mode with Hibernate Search and Elasticsearch dev services #26186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/documentation
area/hibernate-orm
yrodiere
added
release/noteworthy-feature
and removed
area/documentation
area/persistence
area/core
area/hibernate-orm
10 tasks
quarkus-bot
bot
added
area/core
area/documentation
area/hibernate-orm
yrodiere
force-pushed
the
i24923-recreate-schema-in-tests-and-dev-mode
branch
2 times, most recently
from
79d8867
to
2f94145
Compare
yrodiere
force-pushed
the
i24923-recreate-schema-in-tests-and-dev-mode
branch
2 times, most recently
from
9041d1b
to
8a65777
Compare
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
Jun 22, 2022
...kus/hibernate/search/orm/elasticsearch/deployment/HibernateSearchElasticsearchProcessor.java
Outdated
Show resolved
Hide resolved
| devServicesAdditionalConfigProducer | ||
| .produce(new DevServicesAdditionalConfigBuildItem(propertyKeyIndicatingHostsConfigured, | ||
| schemaManagementStrategyPropertyKey, forcedValue, | ||
| () -> LOG.infof("Setting %s=%s to initialize Dev Services managed Elasticsearch server", |
There was a problem hiding this comment.
Not sure about the INFO here. We usually try to avoid verbosity. I don't have a very strong opinion on it but it might be a bit cumbersome if it's the new normal.
There was a problem hiding this comment.
It's consistent with what we do for databases in the ORM extension.
It appears only in dev mode, and before we even display the banner (somewhere around the stuff about docker containers), so I feel it's fine.
But if you want, I can open a ticket and I'll handle that for Hibernate ORM, Hibernate Search, and any other extension that does something like this (I don't think there is any, but I'll check).
There was a problem hiding this comment.
I don't know. Let's leave it at that for now.
...arch/orm/elasticsearch/runtime/HibernateSearchElasticsearchRuntimeConfigPersistenceUnit.java
Outdated
Show resolved
Hide resolved
...arch/orm/elasticsearch/runtime/HibernateSearchElasticsearchRuntimeConfigPersistenceUnit.java
Outdated
Show resolved
Hide resolved
...arch/orm/elasticsearch/runtime/HibernateSearchElasticsearchRuntimeConfigPersistenceUnit.java
Outdated
Show resolved
Hide resolved
…rnate Search and Elasticsearch dev services
…ty keys in Hibernate Search extension
|
Thanks! I definitely need to get "Dev Services" right, next time... Anyway, I addressed your comments. |
yrodiere
force-pushed
the
i24923-recreate-schema-in-tests-and-dev-mode
branch
from
8a65777
to
b0fd4fb
Compare
gsmet
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24923
Supersedes #26175
As explained in #24923, the "validation on startup" feature doesn't make sense here, but dropping and re-creating indexes on startup when using dev services does make sense, especially for tests.
This simplifies configuration:
quarkus.hibernate-orm.database.generation = drop-and-createfor tests / dev modequarkus.hibernate-search-orm.schema-management.strategy = drop-and-create-and-dropfor tests / dev mode(Ok it's not that much simpler, but more PRs are coming)
Creating as draft, because this PR is based on #26184 , which must be merged first.=> Done