Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce @SearchExtension to configure Hibernate Search through annotated beans #26190

Merged
merged 4 commits into from Jul 4, 2022

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jun 16, 2022

Fixes #24922

Creating this PR as draft, because it is based on #26186 , which must be merged first. => Done

@yrodiere yrodiere force-pushed the i24922-search-extension-more branch from 536ef96 to f2077e7 Compare June 20, 2022 07:31
@yrodiere yrodiere force-pushed the i24922-search-extension-more branch 2 times, most recently from 5e066ca to 11e3310 Compare June 23, 2022 08:48
@yrodiere yrodiere marked this pull request as ready for review June 23, 2022 08:49
@quarkus-bot

This comment has been minimized.

@yrodiere yrodiere force-pushed the i24922-search-extension-more branch from 11e3310 to d2ae7a7 Compare June 23, 2022 09:38
@quarkus-bot

This comment has been minimized.

@ebullient ebullient moved this from To do to Docs Team Review in Quarkus Documentation Jun 23, 2022
@ebullient ebullient moved this from Docs Team Review to Reviewer approved in Quarkus Documentation Jun 23, 2022
@ebullient ebullient moved this from Reviewer approved to Review pending in Quarkus Documentation Jun 23, 2022
@yrodiere yrodiere force-pushed the i24922-search-extension-more branch from d2ae7a7 to 1b11a85 Compare June 23, 2022 13:44
@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member Author

yrodiere commented Jun 23, 2022

I've seen the failure and am currently working on solving it. => Done

@yrodiere yrodiere force-pushed the i24922-search-extension-more branch from 1b11a85 to cf52e04 Compare June 23, 2022 16:07
@quarkus-bot

This comment has been minimized.

@yrodiere yrodiere requested a review from gsmet June 28, 2022 10:02
@yrodiere yrodiere added the triage/needs-review Issue that needs a review - remove label if all is clear label Jul 1, 2022
@yrodiere
Copy link
Member Author

yrodiere commented Jul 4, 2022

Hey @Sanne @gsmet , could one of you please review this PR? Thanks in advance :)

Quarkus Documentation automation moved this from Review pending to Reviewer approved Jul 4, 2022
@gsmet gsmet merged commit 304a9b7 into quarkusio:main Jul 4, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Jul 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 4, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 4, 2022
@yrodiere yrodiere deleted the i24922-search-extension-more branch August 2, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/documentation area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search / Elasticsearch area/persistence area/vertx kind/enhancement New feature or request release/noteworthy-feature triage/needs-review Issue that needs a review - remove label if all is clear
Development

Successfully merging this pull request may close these issues.

@SearchExtension: equivalent to @PersistenceUnitExtension for Hibernate Search
3 participants