Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable failing CodeStarts test" #11763

Merged
merged 1 commit into from Sep 1, 2020
Merged

Revert "Disable failing CodeStarts test" #11763

merged 1 commit into from Sep 1, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Sep 1, 2020

This reverts commit 11f3792

@boring-cyborg boring-cyborg bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 1, 2020
@ia3andy ia3andy requested a review from gsmet September 1, 2020 06:05
@ia3andy ia3andy mentioned this pull request Sep 1, 2020
Merged
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 1, 2020
gsmet
gsmet requested changes Sep 1, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me validate it's OK on my laptop before merging as it's where the test didn't pass at all.

@gsmet gsmet self-assigned this Sep 1, 2020
@ia3andy
Copy link
Contributor Author

ia3andy commented Sep 1, 2020

@gsmet should we merge this?

@gsmet
Copy link
Member

gsmet commented Sep 1, 2020

Can't you read my message above?

@ia3andy
Copy link
Contributor Author

ia3andy commented Sep 1, 2020

Can't you read my message above?

@gsmet of course I read it.. it was two hours ago and the CI passed 100% in between, I thought you would have tried it by now and this was just standing by for CI.. My bad :)

@gsmet gsmet merged commit 534dec6 into quarkusio:master Sep 1, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand geoand approved these changes

Assignees

@gsmet gsmet

Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.8.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ia3andy @gsmet @geoand