Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codestarts order bug #11752

Merged
merged 1 commit into from Aug 31, 2020
Merged

Fix codestarts order bug #11752

merged 1 commit into from Aug 31, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Aug 31, 2020

No description provided.

@boring-cyborg boring-cyborg bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Aug 31, 2020
@ia3andy ia3andy requested a review from gsmet August 31, 2020 14:57
@ia3andy ia3andy added this to the 1.8.0 - master milestone Aug 31, 2020
@ia3andy ia3andy mentioned this pull request Aug 31, 2020
Merged
@ia3andy ia3andy mentioned this pull request Aug 31, 2020
Open
gsmet
gsmet previously requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion to explain what I had in mind.

...nt-projects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/CodestartSpec.java Outdated Show resolved Hide resolved
@gsmet gsmet dismissed their stale review August 31, 2020 16:20

Addressed.

@gsmet gsmet merged commit b2812ae into quarkusio:master Aug 31, 2020
@gsmet
Copy link
Member

gsmet commented Aug 31, 2020

@ia3andy can you open a PR to revert the test disablement?

@ia3andy
Copy link
Contributor Author

ia3andy commented Sep 1, 2020

@gsmet what do you mean?

@ia3andy
Copy link
Contributor Author

ia3andy commented Sep 1, 2020

The fix didn't work?

@ia3andy
Copy link
Contributor Author

ia3andy commented Sep 1, 2020 •
edited

@gsmet my bad, I was pretty sure to have removed the disablement in this PR, will do another PR:

#11763

@ia3andy ia3andy deleted the fix-bug-codestart-order branch September 1, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
1.8.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ia3andy @gsmet @gastaldi