Resolve #132

[NullVoxPopuli]

#132
https://stackoverflow.com/questions/71811139/not-able-to-create-a-new-ember-app-could-not-resolve-dependency-error?noredirect=1#comment126901983_71811139

[SergeAstapov]

@NullVoxPopuli shouldn't this be ^3.2.0 || ^4.0.0? I think there is no reason to prevent Ember CLI v3 users

[bertdeblock]

The peerDependencies entry was added a long time ago, but was never released until v3.3.0.
Maybe the safest thing to do, is to completely remove it for now and then release a patch?
We can always re-add it later and release a new major just to be sure?

[bertdeblock]

@quaertym, mind having a look at this PR?
The current peer dependency statement breaks the ember new flow for NPM users. Specifically, the ~3.2.0 part.

[quaertym]

Let's go with ^3.2.0 || ^4.0.0 as suggested above.

[NullVoxPopuli]

Is there a test somewhere to ensure this problem doesn't happen again?

[quaertym]

Not sure what's the best way to test this. But I think it is safe until ember-cli 5.x is released.

[NullVoxPopuli]

I think, this would be a sufficient test to add in your CI:

ember new my-app --skip-npm
cd my-app
# remove line with your dependency
sed  '/"ember-cli-dependency-checker"/d' ./package.json
npm install
npm add --save-dev ember-cli-dependency-checker@file:../foo/bar/wherever
npm install

as long as everything has exit status code 0, that should be sufficient.

[quaertym]

@rwjblue any input on how to test this?

[quaertym]

BTW, I released this as v3.3.1.

[SergeAstapov]

@quaertym I assume we can have ember-try scenarios with different versions of ember-cli, including latest/beta?

[rwjblue]

Ya, using either ember-try or something like scenario-tester seems like the easiest setup.