Replace Travis with GitHub actions #130
Conversation
| - nodejs_version: "10" | ||
| image: | ||
| - Ubuntu | ||
| - Visual Studio 2017 |
There was a problem hiding this comment.
I'll add Windows to testing matrix
|
+1 from me. Let's remove appveyor as well in favor of github actions. |
@quaertym the second commit in this PR does it, see "Remove AppVeyor config" |
|
We can remove the appveyor badge from README and add windows to matrix as you said. |
SergeAstapov
force-pushed
the
travis-to-gh-actions
branch
from
489956a
to
734ddae
Compare
SergeAstapov
force-pushed
the
travis-to-gh-actions
branch
from
734ddae
to
963d443
Compare
|
@quaertym done! tests results - https://github.com/SergeAstapov/ember-cli-dependency-checker/pull/2/checks |
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [8.x, 10.x] |
There was a problem hiding this comment.
@quaertym note 12.x does not work and yarn install fails on Mac OS on fsevents installation.
I think all the dependencies needs to be updated to fix this.
Also, we may release a new major dropping support for older Node.js versions and bumping all the dependencies but it should be separate
There was a problem hiding this comment.
Sounds good. Those that prefer can stay on the older version. But I want to release the bower changes before as a minor version.
There was a problem hiding this comment.
@quaertym agree, that totally makes sense!
|
@quaertym PR was updated, do you mind to turn on/approve GitHub Actions run? |
|
as a follow up I can try to add ember-try scenarios to test against issues like #133 |
|
Thanks, I merged this. I think we should follow ember-cli and use same node versions (12.x, 14.x, 16.x). Any blockers for this? |
|
Sorry for delay - yes, we had to bump dependencies to be able to use newer Node versions, ad it was done in #135 |
Wonder if maintainer is up to this change.