Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #132 #133

Merged
merged 2 commits into from Apr 12, 2022
Merged

Resolve #132 #133

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518790c
Resolve #132
NullVoxPopuli Apr 9, 2022
90ca2db
Update package.json
NullVoxPopuli Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@
"sinon": "^13.0.0"
},
"peerDependencies": {
"ember-cli": "~3.2.0 || ^4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli shouldn't this be ^3.2.0 || ^4.0.0? I think there is no reason to prevent Ember CLI v3 users

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peerDependencies entry was added a long time ago, but was never released until v3.3.0.
Maybe the safest thing to do, is to completely remove it for now and then release a patch?
We can always re-add it later and release a new major just to be sure?

"ember-cli": "^4.0.0"
},
"engines": {
"node": ">= 6"
Expand Down