Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci for pypy3 #2014

Closed
wants to merge 1 commit into from
Closed

add ci for pypy3 #2014

wants to merge 1 commit into from

Conversation

DorianGray
Copy link
Contributor

This adds(readds?) testing of qtile with pypy3

@DorianGray
Copy link
Contributor Author

It looks like github actions does not support pypy3.7 (7.3.3) yet. This will have to hold until it does.

@ramnes
Copy link
Member

ramnes commented Dec 17, 2020

Looks like they heard you! This PR got merged a few hours ago: actions/setup-python#168

pypy-3.7 should work now, if I understand correctly.

@DorianGray
Copy link
Contributor Author

Lets see if it works!

@tych0
Copy link
Member

tych0 commented Dec 17, 2020

Most of these failures look "legit" (aka someone needs to spend some time with the test suite & pypy3 and figure them all out). Given that it works in cpython, I can't imagine there's anything too awful, just a bunch of fiddly stuff.

This matches my understanding of the state of affairs: we had "allowed failure" testing of pypy3 in travis-ci, which basically meant it always failed and nobody paid attention to it :)

@DorianGray
Copy link
Contributor Author

oof, ok. I'll take a look at these as I go and fix what I can then.

@ramnes
Copy link
Member

ramnes commented Dec 17, 2020

Can we close this PR meanwhile?

@DorianGray DorianGray closed this Dec 17, 2020
@DorianGray DorianGray mentioned this pull request Dec 20, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants