Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pypy-3.7 #2028

Closed
3 tasks done
DorianGray opened this issue Dec 20, 2020 · 9 comments
Closed
3 tasks done

Support pypy-3.7 #2028

DorianGray opened this issue Dec 20, 2020 · 9 comments

Comments

@DorianGray
Copy link
Contributor

DorianGray commented Dec 20, 2020

Issue description

I would personally love pypy support in qtile.
Tests already pass, but CI has some obstacles in the way

Qtile version

d6f8a6b / master

TODO

  • wait on github actions to support pypy-3.7
  • wait on tox-gh-actions to support pypy-3.7
  • modify workflow and tox.ini to run on pypy-3.7

Relevant links

actions/setup-python#136
ymyzk/tox-gh-actions#49
#2055

@DorianGray
Copy link
Contributor Author

My PR got merged over on tox-gh-actions, but it might be a bit for a release.

@ramnes
Copy link
Member

ramnes commented Dec 30, 2020

Cool, thanks! Let's get this done.

@DorianGray
Copy link
Contributor Author

All set!

@m-col
Copy link
Member

m-col commented Jan 1, 2021

Could we get something added to the docs about this too? Perhaps a section about the different Python implementations (is that what pypy is?) that we support? Personally this is something I know very little about, but if there are benefits to be taken advantage of then I'd be interested to know how/why/which!

@DorianGray
Copy link
Contributor Author

absolutely! As soon as the tests pass, lol

@DorianGray
Copy link
Contributor Author

Ubuntu/github actions ship pypy3 built against tcl 8.5, not 8.6 like the rest of the pythons. This is the cause of the test failures :/ Looking for a workaround.

@DorianGray
Copy link
Contributor Author

#2055 is update with all tests passing. I'll write up some docs and add them tomorrow.

@DorianGray
Copy link
Contributor Author

docs added, also thanks to @m-col their removal of tkinter no need to skip tests depending on if python was built with a recent version of tk \o/

@DorianGray
Copy link
Contributor Author

Complete =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants