Fix ONNX operator_export_type on the new registry #87735 #90044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pytorch#87313 Our ONNX pipelines do not run with BUILD_CAFFE2=0, so tests for operator_export_type ONNX_ATEN and ONNX_ATEN_FALLBACK will not be fully tested, allowing regressions to happen again. We need to run the same set of tests for both BUILD_CAFFE2=0 and 1 Pull Request resolved: pytorch#87735 Approved by: https://github.com/AllenTiTaiWang, https://github.com/BowenBao (cherry picked from commit 2aed670)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90044
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 FailuresAs of commit 59451a4: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
thiagocrepaldi
approved these changes
Dec 2, 2022
|
@izaitsevfb #88504 needs to be cherry-picked once this PR is merged to have the full fix Thanks for landing this :) |
Thank you for providing the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cherry-pick for the 1.13.1 release.
Original PR: #87735
Below is the description of the original PR.
Fixes #87313
Pytorch's ONNX pipelines do not run with
BUILD_CAFFE2=0, so tests foroperator_export_type==ONNX_ATENorONNX_ATEN_FALLBACKare not fully tested, which caused this regression to the core feature of ONNX exporter: ONNX ATen fallback.This PR fixes this regression, but we discuss with Meta on how to use only
BUILD_CAFFE2=0builds instead of ``BUILD_CAFFE2=1`