Use the Python frame safely in _pythonCallstack (#88993) #89927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the result of `PyEval_GetFrame()` is piped straight to `Py_INCREF`. However, `PyEval_GetFrame` [may return null](https://docs.python.org/3/c-api/reflection.html#c.PyEval_GetFrame), which seems to be the case sometimes, when calling `_pythonCallstack` from another thread. This is handled in the subsequent `while (nullptr != frame)` block, but `Py_INCREF`, called before it, [doesn't handle this case](https://docs.python.org/3/c-api/refcounting.html#c.Py_INCREF), so the program segfaults. The safe form of `Py_INCREF` is `Py_XINCREF`, so use that instead ([docs](https://docs.python.org/3/c-api/refcounting.html#c.Py_XINCREF)). Pull Request resolved: pytorch#88993 Approved by: https://github.com/albanD
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89927
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit afd23b9: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
approved these changes
Nov 30, 2022
|
Closing in favor of #89997 But why is it only triggering 12 to 13 checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the result of
PyEval_GetFrame()is piped straight toPy_INCREF. However,PyEval_GetFramemay return null, which seems to be the case sometimes, when calling_pythonCallstackfrom another thread. This is handled in the subsequentwhile (nullptr != frame)block, butPy_INCREF, called before it, doesn't handle this case, so the program segfaults. The safe form ofPy_INCREFisPy_XINCREF, so use that instead (docs).Pull Request resolved: #88993
Approved by: https://github.com/albanD
Fixes #ISSUE_NUMBER