Fix cuda/cpu check on NoneType #88854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88854
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7192859: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41203955 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41203955 |
mikekgfb
added a commit
to mikekgfb/pytorch
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: pytorch#88854 Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 fbshipit-source-id: c4618a41b1d83c7e7c9263402edc7f4c3643e2b7
mikekgfb
force-pushed
the
export-D41203955
branch
from
7ceaac3
to
5096aa8
Compare
mikekgfb
added a commit
to mikekgfb/pytorch
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: pytorch#88854 Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 fbshipit-source-id: f8d14b3e241a149b35266b134ad622b29379a6d1
mikekgfb
force-pushed
the
export-D41203955
branch
from
5096aa8
to
18d0333
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41203955 |
|
This pull request was exported from Phabricator. Differential Revision: D41203955 |
mikekgfb
added a commit
to mikekgfb/pytorch
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: pytorch#88854 Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 fbshipit-source-id: f472161a5e3389d03035c6461f7cee102018d5fe
mikekgfb
force-pushed
the
export-D41203955
branch
from
18d0333
to
1459c0c
Compare
mikekgfb
added a commit
to mikekgfb/pytorch
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: pytorch#88854 Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Reviewed By: drisspg Differential Revision: D41203955 fbshipit-source-id: a6b1b5d4aec0d5d2efc0483cefd07b431b83473e
mikekgfb
force-pushed
the
export-D41203955
branch
from
1459c0c
to
adedf1d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41203955 |
Summary: Pull Request resolved: pytorch#88854 Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Reviewed By: drisspg Differential Revision: D41203955 fbshipit-source-id: b44de88b8f7f856706ee76a4a5702f392b07075b
ngimel
approved these changes
Nov 11, 2022
| @@ -1114,7 +1114,7 @@ def forward(self, query: Tensor, key: Tensor, value: Tensor, key_padding_mask: O | |||
| # generator expressions. | |||
| if torch.overrides.has_torch_function(tensor_args): | |||
| why_not_fast_path = "some Tensor argument has_torch_function" | |||
| elif not all([(x.is_cuda or 'cpu' in str(x.device)) for x in tensor_args]): | |||
| elif not all([(x is None or x.is_cuda or 'cpu' in str(x.device)) for x in tensor_args]): | |||
There was a problem hiding this comment.
pre-existing condition, but proper check is x.device.type=='cpu'
mikekgfb
force-pushed
the
export-D41203955
branch
from
adedf1d
to
7192859
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41203955 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Also addresses #88669 |
weiwangmeta
pushed a commit
to weiwangmeta/pytorch
that referenced
this pull request
Dec 2, 2022
Summary: Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 Pull Request resolved: pytorch#88854 Approved by: https://github.com/drisspg, https://github.com/ngimel
This was referenced Dec 2, 2022
weiwangmeta
pushed a commit
to weiwangmeta/pytorch
that referenced
this pull request
Dec 6, 2022
Summary: Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 Pull Request resolved: pytorch#88854 Approved by: https://github.com/drisspg, https://github.com/ngimel
atalman
pushed a commit
that referenced
this pull request
Dec 6, 2022
Summary: Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 Pull Request resolved: #88854 Approved by: https://github.com/drisspg, https://github.com/ngimel Co-authored-by: Michael Gschwind <mikekg@meta.com>
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: Fix cuda/cpu check on NoneType Test Plan: sabdcastle/ github CI/CD Differential Revision: D41203955 Pull Request resolved: pytorch#88854 Approved by: https://github.com/drisspg, https://github.com/ngimel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix cuda/cpu check on NoneType
Test Plan: sabdcastle/ github CI/CD
Differential Revision: D41203955