New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: C++ runtime on Windows #2806
base: main
Are you sure you want to change the base?
Conversation
ca990f0
to
5aad5b7
Compare
Some observations about the failed tests.
|
68bcec0
to
f4ec270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and thank you very much for the contribution. Added a few questions/comments. The comments on the test cases + added fixes look good and switching np.dtype("i")
to np.int32
for that case is fine to include in the converter.
1d827f8
to
1723246
Compare
d52ac0f
to
6b7a9e0
Compare
6b7a9e0
to
8915f84
Compare
No ciflow labels are configured for this repo. |
8915f84
to
361e937
Compare
a065cb3
to
137dfba
Compare
Hi @HolyWu - I wanted to share a few notes on the C++ runtime on Windows after some local testing:
Based on the GHA-installed package, I ran the CI-failing tests, for which I have the following results:
|
7a1d667
to
f1c1c49
Compare
Thanks for the notes. I have fixed the version of transformers and also add a missing test. As for the error you encountered during ninja build, I haven't seen the exact same error. But I suspect you probably didn't run |
Thanks for the suggestions. I also added Python310\include\pyconfig.h(59): fatal error C1083: Cannot open include file: 'io.h': No such file or directory |
|
Hi @HolyWu - thanks for the suggestion. Ultimately, the issue was that the repo directory was not its original name, and so the For some reason when importing the built package however, it shows The line causing the issue is where the library is registered with PyTorch and ultimately loaded, here:
|
Was added in pytorch#2750
f1c1c49
to
ded00ff
Compare
I have no clue. |
Description
Fix and enable C++ runtime on Windows.
Fixes #2247
Fixes #2371
Fixes #2484
Type of change
Checklist: