Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add release flag for nightly build tag #2821

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 7, 2024

Description

Type of change

  • Address CI Issue

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@HolyWu
Copy link
Contributor

HolyWu commented May 8, 2024

wheel-build-params is a bit special. It only has an effect when env-script is also specified. We don't necessarily have to use --release flag here, since setup.py also checks RELEASE env var. So I made the relevant changes.

@gs-olive
Copy link
Collaborator Author

gs-olive commented May 8, 2024

@HolyWu - thanks for this detail. I wanted to add the release specification to the nightly builds in advance of getting your PR #2806 merged, and to get this change to another branch which only has the Python runtime for Windows. I can cherry-pick your env var commit 6b7a9e0 into this PR instead

Update: Cherry-picked and reformatted the change to only include the environment variable insertion to get main and release/2.3 updated in advance of #2806 getting merged

Use env var instead of wheel-build-params for release flag
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 2972182 into main May 14, 2024
53 checks passed
@gs-olive gs-olive deleted the windows_build_params branch May 14, 2024 20:54
gs-olive added a commit that referenced this pull request May 14, 2024
Co-authored-by: HolyWu <holywu@gmail.com>
gs-olive added a commit that referenced this pull request May 14, 2024
Co-authored-by: HolyWu <holywu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants