Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make order of processing the builtins SCC predictable #12431

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Mar 23, 2022

Various things can go wrong if the order of modules in the builtins
SCC that also includes typing, _typeshed and others is adjusted.

Hopefully fixes #12422. May also fix #12421.

Various things can go wrong if the order of modules in the builtins
SCC that also includes typing, _typeshed and others is adjusted.

Hopefully fixes #12422.
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL JukkaL merged commit fd8a15e into master Mar 23, 2022
@JukkaL JukkaL deleted the fix-builtins-scc branch March 23, 2022 13:33
JukkaL added a commit that referenced this pull request Mar 23, 2022
Various things can go wrong if the order of modules in the builtins
SCC that also includes typing, _typeshed and others is adjusted.

Hopefully fixes #12422. May also fix #12421.
@hauntsaninja
Copy link
Collaborator

Oh, interesting. I wonder if this will fix issues like #11535 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit type aliases fail in typeshed mypy fails for a simple Any type alias`
2 participants