Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit type aliases fail in typeshed #12422

Closed
Tracked by #4913
srittau opened this issue Mar 22, 2022 · 2 comments · Fixed by #12431
Closed
Tracked by #4913

Explicit type aliases fail in typeshed #12422

srittau opened this issue Mar 22, 2022 · 2 comments · Fixed by #12431
Labels
affects-typeshed Anything that blocks a typeshed change bug mypy got something wrong topic-type-alias TypeAlias and other type alias issues

Comments

@srittau
Copy link
Contributor

srittau commented Mar 22, 2022

I can't reproduce this locally, but please have a look at the CI failures of python/typeshed#7534. The change is adding explicit type aliases to _typeshed/*. CI runs mypy 0.941 with all Python versions.
@srittau srittau added the bug mypy got something wrong label Mar 22, 2022
@srittau srittau mentioned this issue Mar 22, 2022
Closed
7 tasks
@JelleZijlstra JelleZijlstra added the topic-type-alias TypeAlias and other type alias issues label Mar 22, 2022
@JelleZijlstra
Copy link
Member

For reference #11305 added PEP 613 support.

JukkaL added a commit that referenced this issue Mar 23, 2022
@JukkaL
Make order of processing the builtins SCC predictable
74f1c8f 
Various things can go wrong if the order of modules in the builtins
SCC that also includes typing, _typeshed and others is adjusted.

Hopefully fixes #12422.
@JukkaL JukkaL mentioned this issue Mar 23, 2022
Merged
JukkaL added a commit that referenced this issue Mar 23, 2022
@JukkaL
Make order of processing the builtins SCC predictable (#12431)
fd8a15e 
Various things can go wrong if the order of modules in the builtins
SCC that also includes typing, _typeshed and others is adjusted.

Hopefully fixes #12422. May also fix #12421.
JukkaL added a commit that referenced this issue Mar 23, 2022
@JukkaL
Make order of processing the builtins SCC predictable (#12431)
367b29d 
Various things can go wrong if the order of modules in the builtins
SCC that also includes typing, _typeshed and others is adjusted.

Hopefully fixes #12422. May also fix #12421.
@AlexWaygood
Copy link
Member

Happy to confirm that #12431 solved this issue — now only the pytype test is failing in typeshed's CI (python/typeshed#7534) 🎉

@AlexWaygood AlexWaygood added the affects-typeshed Anything that blocks a typeshed change label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-typeshed Anything that blocks a typeshed change bug mypy got something wrong topic-type-alias TypeAlias and other type alias issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make order of processing the builtins SCC predictable python/mypy
3 participants
@srittau @JelleZijlstra @AlexWaygood