Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable --fast-exit by default to speed up mypy #11541

Merged
merged 2 commits into from
Nov 14, 2021
Merged

Enable --fast-exit by default to speed up mypy #11541

merged 2 commits into from
Nov 14, 2021

Commits on Nov 13, 2021

  1. Enable --fast-exit by default 

    This means that we kill the mypy process at exit instead of cleanly
freeing up memory. This speeds up mypy runs by ~10% in some cases
(with compiled mypy).

We've been using this internally at work for a long time without any
issues.

Previously the slowdown was visible as a small delay after the final
message from mypy was printed.

I measured the impact on a branch with some other optimizations as
well, so on master the fraction would be slightly less, as other
things would be slower.
    @JukkaL
    JukkaL committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    b45affc View commit details
    Browse the repository at this point in the history

  2. Don't use --fast-exit for runs via the mypy api

    @JukkaL
    JukkaL committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    10d99fd View commit details
    Browse the repository at this point in the history