Enable --fast-exit by default to speed up mypy #11541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we kill the mypy process at exit instead of cleanly freeing up memory. This speeds up mypy runs by ~10% in some cases (with compiled mypy). We've been using this internally at work for a long time without any issues. Previously the slowdown was visible as a small delay after the final message from mypy was printed. I measured the impact on a branch with some other optimizations as well, so on master the fraction would be slightly less, as other things would be slower.
|
Related to #11547. |
|
Added a comment to #6617. |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Closes python#6662. This means that we kill the mypy process at exit instead of cleanly freeing up memory. This speeds up mypy runs by ~10% in some cases (with compiled mypy). We've been using this internally at work for a long time without any issues. Previously the slowdown was visible as a small delay after the final message from mypy was printed. I measured the impact on a branch with some other optimizations as well, so on master the fraction would be slightly less, as other things would be slower. Don't use --fast-exit for runs via the mypy api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we kill the mypy process at exit instead of cleanly
freeing up memory. This speeds up mypy runs by ~10% in some cases
(with compiled mypy).
We've been using this internally at work for a long time without any
issues.
Previously the slowdown was visible as a small delay after the final
message from mypy was printed.
I measured the impact on a branch with some other optimizations as
well, so on master the fraction would be slightly less, as other
things would be slower.