Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use level "note" for reveal_type and reveal_locals #6919

Merged
merged 4 commits into from Jun 18, 2019
Merged

Use level "note" for reveal_type and reveal_locals #6919

merged 4 commits into from Jun 18, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 1, 2019 •
edited

Fixes #6901.

TODO:

  • indentation with reveal_locals

ilevkivskyi
ilevkivskyi approved these changes Jun 1, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle I like this change (you can also indent revealed locals as discussed in the issue). But this is changes huge amount of tests, so I think this requires approval from most of core team members.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 1, 2019

Great.

so I think this requires approval from most of core team members.

Ok, no hurry - I can see that this might cause trouble with pending PRs etc.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 3, 2019

  • indentation with reveal_locals

As for this: do you think prepending " - " is good here?

JukkaL
JukkaL approved these changes Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. It may be worth coordinating when to merge this as this goes stale quickly.

@blueyed blueyed changed the title [RFC/WIP] Use level "note" for reveal_type and reveal_locals Use level "note" for reveal_type and reveal_locals Jun 3, 2019
@ilevkivskyi
Copy link
Member

As for this: do you think prepending " - " is good here?

I think just four spaces offset is enough (like in protocol error message notes)

@blueyed
Copy link
Contributor Author

blueyed commented Jun 5, 2019

Ok, updated and rebased.

@msullivan
Copy link
Collaborator

Sure! If you rebase it again I'll merge it.

@blueyed
Use level "note" for reveal_type and reveal_locals
8b4ee3e 
Fixes python#6901.
@blueyed
Update tests
241e882 
- sed -i 's/# E: Revealed type/# N: Revealed type/g' test-data/**/*.test
- sed -i 's/: error: Revealed type/: note: Revealed type/g' test-data/**/*.test
@blueyed
Update tests for reveal_locals
bb4186a
@blueyed
reveal_locals: indent following lines with 4 spaces
8270705
@blueyed
Copy link
Contributor Author

blueyed commented Jun 18, 2019

@msullivan
Ok, hope it stays green.

@msullivan msullivan merged commit cb7b242 into python:master Jun 18, 2019
@blueyed blueyed deleted the reveal-note branch June 18, 2019 00:30
gvanrossum pushed a commit that referenced this pull request Jun 18, 2019
@blueyed
Use level "note" for reveal_type and reveal_locals (#6919)
7cd264a 
Tests were fixed using:
- sed -i 's/# E: Revealed type/# N: Revealed type/g' test-data/**/*.test
- sed -i 's/: error: Revealed type/: note: Revealed type/g' test-data/**/*.test

Fixes #6901.
@gvanrossum gvanrossum mentioned this pull request Jun 18, 2019
Closed
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@blueyed @PattenR
Use level "note" for reveal_type and reveal_locals (python#6919)
9f04044 
Tests were fixed using:
- sed -i 's/# E: Revealed type/# N: Revealed type/g' test-data/**/*.test
- sed -i 's/: error: Revealed type/: note: Revealed type/g' test-data/**/*.test

Fixes python#6901.
@ikonst ikonst mentioned this pull request Jun 24, 2019
Merged
ikonst added a commit to pynamodb/PynamoDB that referenced this pull request Jun 25, 2019
@ikonst
tests: bump to mypy 0.710
a496171 
Update mypy output parser for python/mypy#6919
@ikonst ikonst mentioned this pull request Jun 25, 2019
Merged
@msherry msherry mentioned this pull request Jul 15, 2019
Closed
@blueyed blueyed mentioned this pull request Dec 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@ethanhs ethanhs ethanhs approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reveal_type / reveal_locals should not use "error" but "note"
5 participants
@blueyed @ilevkivskyi @msullivan @JukkaL @ethanhs