Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy reveal_type() gets suppressed #38

Closed
efroemling opened this issue Jul 15, 2019 · 1 comment
Closed

Mypy reveal_type() gets suppressed #38

efroemling opened this issue Jul 15, 2019 · 1 comment

Comments

@efroemling
Copy link
Contributor

I just came back to a project after a while and noticed that I'm no longer able to do use Mypy's reveal_type() with pycheckers. Mypy is emitting an error level of 'note:' in this case which seems to get filtered out by fixup_data() in pycheckers' mypy checker. Perhaps mypy used to emit errors and not notes for reveal_type()?..
I'm able to work around it for now by hacking fixup_data() to map that particular case back to an error, but perhaps you'd want to fix this in a cleaner way? (I'd be happy to throw my hack up as a PR if not; just let me know)
-Eric

@msherry
Copy link
Owner

msherry commented Jul 15, 2019

It looks like the level for reveal_type messages changed in python/mypy#6919. It sounds like we should probably display messages at the note level, since there are at least two debugging functions (reveal_type and reveal_locals) that use it now.

I'll take a look and see if I can get a fix up shortly -- thanks for bringing it to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants