Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unused 'type: ignore' comment" should be of severity "warning" / "note" #8060

Open
blueyed opened this issue Dec 3, 2019 · 1 comment
Open

Comments

@blueyed
Copy link
Contributor

blueyed commented Dec 3, 2019

I think the "unused 'type: ignore' comment" errors should be not of type "error", but rather "note" (or "warning", but that does not exist yet really AFAICS).

While changing this to "note" would be trivial, I think it should be considered to start using a severity of "warning", and use this here then.

(This is relevant for when using mypy as a linter, where the type of "error" is relevant.
I am transforming "Need type (annotation|comment) for …" errors to "info" already for example, but that should really be reflected in mypy's output already in a better way.
Related: #6919.)

@JukkaL
Copy link
Collaborator

JukkaL commented Dec 3, 2019

Yeah, if we had support for a 'warning' error level this would make sense. Leaving as 'needs discussion' since we haven't really considered the impliciations of adding a 'warning' error level.

@AlexWaygood AlexWaygood added the topic-type-ignore # type: ignore comments label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants