Tentative PyJWT-2.0.0-related fixes #537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version changed `jwt.encode()` to return a str instead of a bytes. The change preserves compatibility with both new and older PyJWT
This takes care of two changes:
- The name ExpiredSignature, deprecated in favor of ExpiredSignatureError,
was dropped
- `jwt.decode(verify=False)` needs to be rephrased as
`jwt.decode(options={'verify_signature': False})`
Used `algorithm='RS256'` as is done with jwt.encode() but in decode() it's plural `algorithms` and it sets which algorithms are valid -- so it needs to be a list and not a string.
... and appears unrelated to the changes at hand
|
good stuff, wonder what the status of this is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Coming on top of #536, these are changes which I could not test -- they are not currently causing test failures in the python-social-core test suite, and they are in backends which I do not use and am not familiar with. But they seemed obvious enough to at least suggest.
In particular, I suspect the change in 4937977 may fix the Apple ID issue mentioned in #503 (comment).
Types of changes
Please check the type of change your PR introduces:
Checklist
This PR is made on behalf of Matific -- https://www.matific.com -- https://github.com/SlateScience