Support PyJWT 2.0.0 #536
Merged
Support PyJWT 2.0.0 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version changed `jwt.encode()` to return a str instead of a bytes. The change preserves compatibility with both new and older PyJWT
This takes care of two changes:
- The name ExpiredSignature, deprecated in favor of ExpiredSignatureError,
was dropped
- `jwt.decode(verify=False)` needs to be rephrased as
`jwt.decode(options={'verify_signature': False})`
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The release of PyJWT 2.0.0 last week included some backwards-incompatible changes.
This adapts some tests and the Azure backends to support the new release (while still supporting the older 1.7.1 version).
One suggestion to solve the problems was to pin PyJWT down to 1.7.1 (that is #532).
The issue was also discussed a little in #503.
Types of changes
Please check the type of change your PR introduces:
Checklist
(The tests are failing before this PR. It fixes them)
(One test has been freezing for me locally; I thought it may have been an issue with my setup, but I've seen that it froze in CI as well. I skipped it locally, after verifying that it freezes the same way with either PyJWT 1.7.1 or 2.0.0. The skipping is done in
3809cd1 which is part of the followup PR of tentative changes #537)
Additional information
This PR is made on behalf of Matific -- https://www.matific.com -- https://github.com/SlateScience