Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump flake8 additional dependencies #5662

Merged
merged 3 commits into from May 22, 2022
Merged

Bump flake8 additional dependencies #5662

merged 3 commits into from May 22, 2022

Commits on May 22, 2022

  1. chore(pre-commit): bump flake8 additional dependencies

    @mkniewallner
    mkniewallner committed May 22, 2022
    Configuration menu
    Copy the full SHA
    c880fcf View commit details
    Browse the repository at this point in the history

  2. refactor: remove unnecessary maps to respect C417

    @mkniewallner
    mkniewallner committed May 22, 2022
    Configuration menu
    Copy the full SHA
    b1a6ef5 View commit details
    Browse the repository at this point in the history

  3. refactor: ensure garbage collection of objects using lru cache 

    Decorating class instances methods using `lru_cache` prevents garbage collection
to happen when an object gets deleted. This could be really bad for memory
consumption.
Some resources about this:
- https://rednafi.github.io/reflections/dont-wrap-instance-methods-with-functoolslru_cache-decorator-in-python.html
- https://www.youtube.com/watch?v=sVjtp6tGo0g

Originally spotted by rule `B019` of `flake8-bugbear`.
    @mkniewallner
    mkniewallner committed May 22, 2022
    Configuration menu
    Copy the full SHA
    356766e View commit details
    Browse the repository at this point in the history