Bump flake8 additional dependencies
#5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decorating class instances methods using `lru_cache` prevents garbage collection to happen when an object gets deleted. This could be really bad for memory consumption. Some resources about this: - https://rednafi.github.io/reflections/dont-wrap-instance-methods-with-functoolslru_cache-decorator-in-python.html - https://www.youtube.com/watch?v=sVjtp6tGo0g Originally spotted by rule `B019` of `flake8-bugbear`.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Added tests for changed code.Not applicableUpdated documentation for changed code.Not applicableSimilarly to python-poetry/poetry-core#362, update flake8 dependencies.
b1a6ef5 updates some assignments to avoid unnecessary
map, according to the new C417 rule from flake8-comprehensions.356766e is a bit more tricky. It updates misuses of
lru_cachethat prevent class instances from being garbage collected when it is applied on class instances methods.This is reported by the new B019 rule of flake8-bugbear.
Some resources about this:
Changelogs: