Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with FriBiDi on Alpine #274

Merged
merged 1 commit into from Mar 31, 2022
Merged

Test with FriBiDi on Alpine #274

merged 1 commit into from Mar 31, 2022

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Mar 31, 2022

@hugovk
Copy link
Member

hugovk commented Mar 31, 2022

python-pillow/Pillow#6165 is merged and this build restarted.

The musllinux ones pass for linux-latest and fail for linux: expected, right?

The reason I ask is the linux-latest failed and linux passed on this:

See passing in my repository until the above is merged: nulano/pillow-wheels/runs/5764443231?check_suite_focus=true#step:4:6501

@nulano
Copy link
Contributor Author

nulano commented Mar 31, 2022

The musllinux ones pass for linux-latest and fail for linux: expected, right?

Yes, linux-latest is building with main which includes the fix, linux builds the last release which doesn't.

The reason I ask is the linux-latest failed and linux passed on this: nulano/pillow-wheels/...

For the test in my repo I changed the selected tag to the fix branch (so linux passed), but linux-latest was grabbing the upstream main branch (without the fix).

@hugovk
Copy link
Member

hugovk commented Mar 31, 2022

Thanks!

@hugovk hugovk merged commit 8ee683d into python-pillow:main Mar 31, 2022
@nulano nulano deleted the fribidi branch March 31, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants