Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pillow 9.1.0 on April 1, 2022 #6110

Closed
20 tasks done
radarhere opened this issue Mar 4, 2022 · 17 comments
Closed
20 tasks done

Release Pillow 9.1.0 on April 1, 2022 #6110

radarhere opened this issue Mar 4, 2022 · 17 comments
Assignees
Labels
Milestone

Comments

@radarhere
Copy link
Member

radarhere commented Mar 4, 2022

Main Release

Released quarterly on January 2nd, April 1st, July 1st and October 15th.

  • Open a release ticket e.g. Release Pillow 5.2.0 on July 1, 2018 #3154
  • Develop and prepare release in main branch.
  • Check GitHub Actions and AppVeyor to confirm passing tests in main branch.
  • Check that all of the wheel builds Pillow Wheel Builder pass the tests in Travis CI and GitHub Actions.
  • In compliance with PEP 440, update version identifier in src/PIL/_version.py
  • Update CHANGES.rst.
  • Run pre-release check via make release-test in a freshly cloned repo.
  • Create branch and tag for release e.g.:
    git branch 5.2.x
    git tag 5.2.0
    git push --all
    git push --tags
  • Create and check source distribution:
    make sdist
    twine check dist/*
  • Create binary distributions
  • Check and upload all binaries and source distributions e.g.:
    twine check dist/*
    twine upload dist/Pillow-5.2.0*
  • Publish the release on GitHub
  • In compliance with PEP 440, increment and append .dev0 to version identifier in src/PIL/_version.py

Binary Distributions

Windows

Mac and Linux

Publicize Release

Documentation

Docker Images

  • Update Pillow in the Docker Images repository
    git clone https://github.com/python-pillow/docker-images
    cd docker-images
    ./update-pillow-tag.sh [[release tag]]
@radarhere radarhere added this to the 9.1.0 milestone Mar 4, 2022
@radarhere radarhere pinned this issue Mar 4, 2022
@hugovk hugovk self-assigned this Mar 4, 2022
@radarhere
Copy link
Member Author

It has been pointed out that we should not use PyPy 7.3.8 for this release.

I'm hopeful that PyPy 7.3.9 will be released before April 1 though.

@radarhere
Copy link
Member Author

PyPy 7.3.9 has now been merged in, with python-pillow/pillow-wheels#272

@hugovk
Copy link
Member

hugovk commented Mar 31, 2022

Okay, main is more or less ready for release.

Needed:

To consider:

@radarhere Please also merge anything else you think is good, and I'll start the release tomorrow (Finnish) morning. Thanks!

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

@cgohlke Please could we have Windows binaries for 9.1.0? Thank you!

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

@radarhere Thanks for bumping the docker-images, but I was a bit confused why this "Create release" job has been waiting for over 40 minutes for a runner and I guess it's because the CI capacity is tied up at docker-images :D

image

In general, it's probably best to hold off to keep the CI free in case of necessary re-runs (we're on the third so far), and the docker-images bump is the last thing on the checklist so I won't forget it. Thanks!

@radarhere
Copy link
Member Author

I don't think it is because of that. I waited 20 minutes for it to start before I gave up and triggered docker-images :p

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

Hmm, weird! I'll give it another 10 minutes and then cancel and start a fourth attempt!

Anyway, the docker-images update isn't for the actual release, so in the future let's wait until afterwards.

Relating to the first two failed attempts, I filed these for the timeout and "re-run failed" problems:

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

Still waiting after an hour:

image

https://github.com/python-pillow/pillow-wheels/runs/5786245264?check_suite_focus=true

I'm curious to see if it'll timeout, so I've left it running and have triggered a new build on the tag:

image

https://github.com/python-pillow/pillow-wheels/actions/runs/2076994216

@radarhere
Copy link
Member Author

While it would be good to eventually have the GitHub Release for pillow-wheels, if you get to the point where you just want the wheels, the wheels-latest artifact from a recent run of my pillow-wheels has that.

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

Thanks! Will use those if it doesn't succeed by the time the Windows ones are available.

@cgohlke
Copy link
Contributor

cgohlke commented Apr 1, 2022

Please could we have Windows binaries for 9.1.0?

Here you go.

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

Please could we have Windows binaries for 9.1.0?

Here you go.

Thanks!


Thanks! Will use those if it doesn't succeed by the time the Windows ones are available.

10th attempt had no timeouts but again the final Create Release job is still "Waiting for a runner to pick up this job...", so will use those.

image

https://github.com/python-pillow/pillow-wheels/runs/5789145831?check_suite_focus=true

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

Released! 🚀

https://pypi.org/project/Pillow/9.1.0/

Thanks all!

(Tweet to come)

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

@aclark4life
Copy link
Member

And pinned, thanks all!!

Screen Shot 2022-04-01 at 12 42 43 PM

@hugovk hugovk mentioned this issue Apr 1, 2022
@radarhere
Copy link
Member Author

radarhere commented Apr 2, 2022

@hugovk here are the aarch64 wheels from Travis CI, if it helps - aarch64.zip

@hugovk
Copy link
Member

hugovk commented Apr 2, 2022

Thanks, uploaded!

image

https://pypi.org/project/Pillow/9.1.0/#files

@radarhere radarhere unpinned this issue Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants