Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python 3.10 Linux jobs #217

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Conversation

radarhere
Copy link
Member

After matthew-brett/trusty#13 and matthew-brett/trusty#17, and updating multibuild to include https://github.com/matthew-brett/multibuild/pull/423 to change MB_ML_VER to 2014 as suggested in https://github.com/matthew-brett/multibuild/issues/421#issuecomment-898354903, this PR adds Python 3.10 jobs for Linux.

@hugovk
Copy link
Member

hugovk commented Aug 26, 2021

Thank you!

For PyPy3/Linux: do we need to update MB_ML_VER to 2014 and DOCKER_TEST_IMAGE to focal in build.sh?

if [[ "$MB_PYTHON_VERSION" == pypy3* ]]; then
  if [[ "$TRAVIS_OS_NAME" != "macos-latest" ]]; then
    MB_ML_VER="2010"
    DOCKER_TEST_IMAGE="multibuild/xenial_$PLAT"
  else
    MB_PYTHON_OSX_VER="10.9"
  fi
fi

And this is likely a longer term multibuild question and not immediately relevant here: should it use something newer than Trusty 14.04?

@radarhere
Copy link
Member Author

https://github.com/pypa/manylinux

manylinux2010 (CentOS 6 based - EOL)

Since 2010 is EOL, updating to MB_ML_VER to 2014 seems like a good idea, sure.

@radarhere
Copy link
Member Author

radarhere commented Aug 26, 2021

As has been said, there aren't focal docker images for 32-bit. Is dropping support for 32-bit Linux wheels something that we're interested in doing? At the very least, I didn't think that this PR was the right place for that.

Regarding other options, there are some problems at the moment -

/usr/bin/choose_python.sh: line 68: python: command not found

(edit: added in #218)

Features should be: 'fribidi harfbuzz raqm transp_webp webp_anim webp_mux xcb'; but are 'transp_webp webp_anim webp_mux xcb'

AttributeError: module 'sysconfig' has no attribute 'get_preferred_scheme'

So this PR is the simplest option for the moment.

@hugovk
Copy link
Member

hugovk commented Aug 26, 2021

The point of this PR is to add 3.10 for Linux, so agreed best to keep it simple and let's merge this. Thanks for trying that lot out.

Dropping 32-bit: something to consider, download numbers are pretty low, but let's discuss it another time in the main repo.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants