New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Python 3.10 wheels. #245
Conversation
It appears I was able to fix the build stages, but the testing is stymied by lack of Pillow wheels. Not sure if you want to work around that or wait for them. |
Thanks for this. I'd prefer to wait for Pillow's 3.10 wheels to be released; we have time since Python 3.10 won't be released until October. |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 96.59% 96.43% -0.16%
==========================================
Files 37 37
Lines 3877 3788 -89
==========================================
- Hits 3745 3653 -92
- Misses 132 135 +3
Continue to review full report at Codecov.
|
It looks like Pillow has 3.10 wheels now, but for some reason, 3.6 doesn't load it and uses the sdist again https://github.com/QuLogic/pikepdf/runs/3501350170?check_suite_focus=true Maybe everything isn't fully mirrored yet and I should wait a few hours. |
Also Windows fails building lxml for Python 3.10, which apparently has manylinux wheels, but not win32 or win64. |
Maybe something to do with upgrading from manylinux1 to manylinux2014?
|
@QuLogic Thanks for investigating. It looks to me like Pillow has moved to manylinux2014 and has stopped supporting manylinux2010. For what it's worth I complained that they should consider this is a breaking change and should bump their major version number. Setting That said, since pikepdf 3.x is just around the corner, I am strongly considering moving to manylinux2014 and dropping Python 3.6 (since it is two months from end of life) to avoid further drama. Maybe also switching from C++14 to 17. |
@hugovk I believe it does have to do with the switch to manylinux2014 - reported at python-pillow/Pillow#5701 |
I've done further work on this - very like we'll need to drop Python 3.6 support and release pikepdf 4.0. Currently everything is ready to go except that we are waiting for lxml to release Python 3.10 wheels, especially for Windows. |
Implemented in pikepdf 4.0; many thanks for this contribution which kicked off Python 3.10. |
From the 3.10 release notes:
So it is, roughly-speaking, safe to start building 3.10 wheels, but it seems we need to wait for pillow: python-pillow/Pillow#5569
I managed to fix a bug in the CI setup, but there's still something missing to get Pillow to load correctly in all tests.