New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on new Travis CPUs #4336
Merged
Merged
Test on new Travis CPUs #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oooh. Big Endian. |
radarhere
reviewed
Jan 7, 2020
homm
reviewed
Jan 8, 2020
…is CI Co-Authored-By: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Also moved the scripts from |
You mention in the initial description that you intended this as a draft PR. Is there still work to be done? |
No, ready for review! |
7 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps for #3606.
New CPU architectures
Now we've moved a lot of testing to GitHub Actions, we should still use Travis CI for testing things which are unique to it, to get good coverage.
Travis has recently made available new CPU architectures, in addition to the existing
amd64
.In July, they added
arm64
(Arm support)https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support
In November, they added
ppc64le
(IBM Power) ands390x
(IBM Z CPU)https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z
s390x
is particularly useful as it's big-endian, and we have a number of big-endian issuesChanges proposed in this pull request
Run tests on the new
arm64
,ppc64le
ands390x
architecturesSkip install of pyqt5 because "ERROR: Could not find a version that satisfies the requirement pyqt5"
The known
s390x
test failures (Big-endian test failures on IBM Z #4213) are skipped as expected failures when run on CI: we should still aim to fix them, but there's value in running the other testsThis draft* PR is to illustrate the new CPUs on each Python version. I don't intend we test them all on Python versions, just a single version for each CPU.
(* Was meant to be a draft but I clicked the wrong button...)
Cold cache
https://travis-ci.org/hugovk/Pillow/builds/632753494
Warm cache
https://travis-ci.org/hugovk/Pillow/builds/632884754
Generally the cold cache build times are about the same for each Python version, with newer versions a bit slower than older ones, except 3.8 on
s390x
is many times slower.Warm cache times are closer, but let's optimise for cold caches, which is the case for PR branches.
Suggestion
Avoid Python 3.8 for now, spread over other versions. For example:
s390x
on Python 3.5arm64
on Python 3.6ppc64le
on Python 3.7