Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected failures on big endian systems without CI #4791

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

kulikjak
Copy link
Contributor

Changes proposed in this pull request:

  • remove on_ci checks from endianess related xfail decorators. It doesn't matter whether tests are running on CI or not for those tests to fail (we are running those tests without CI).

@radarhere
Copy link
Member

These were added in #4336. I presume the intention by @hugovk was to not prevent our CI from running other tests, but also not to hide the failures from end users. However, I'm guessing that you feel that marking them as xfail is sufficient?

@hugovk hugovk added the Big-endian Big-endian processors label Jul 16, 2020
@hugovk
Copy link
Member

hugovk commented Jul 16, 2020

Yes, that's about right, and I think xfail is sufficient as they'll still be shown in the logs:

XFAIL Tests/test_file_jpeg2k.py::test_16bit_monochrome_jp2_like_tiff
  Fails on big-endian
XFAIL Tests/test_file_jpeg2k.py::test_16bit_monochrome_j2k_like_tiff
  Fails on big-endian
XFAIL Tests/test_file_palm.py::test_p_mode
  Palm P image is wrong
XFAIL Tests/test_file_png.py::TestFilePng::test_sanity
  Fails on big-endian
XFAIL Tests/test_file_webp_animated.py::test_write_animation_L
  Fails on big-endian

https://travis-ci.org/github/python-pillow/Pillow/jobs/708663515#L4544

It's good people are testing big-endian locally too, maybe someone will be able to fix them? :)

Thanks for the PR!

@radarhere radarhere merged commit a7d1a88 into python-pillow:master Jul 16, 2020
@hugovk hugovk added the Testing label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Big-endian Big-endian processors Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants