Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Docker with GitHub Actions #4066

Merged
merged 1 commit into from Oct 9, 2019
Merged

Test Docker with GitHub Actions #4066

merged 1 commit into from Oct 9, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 14, 2019 •
edited

For #3606.

Changes proposed in this pull request:

  • Run Docker tests using GitHub Actions
  • GitHub Actions testing now identical to Azure Pipelines, 13 jobs
  • Main difference:
    • AZP 10 parallel jobs, so 3 wait. Whole run ~6 mins
    • GHA 20 parallel jobs, so none wait. Whole run ~3 mins

Shall we remove the AZP tests now or have both enabled for a while to compare and evaluate?

(Coverage still needed before removing Docker from Travis, can follow.)

@hugovk hugovk added the Build label Sep 14, 2019
@radarhere

This comment has been minimized.

Sign in to view
@hugovk

This comment has been minimized.

Sign in to view
@hugovk hugovk added the Testing label Sep 15, 2019
This was referenced Sep 22, 2019
Merged
Closed
@hugovk hugovk changed the title Test Docker builds with GitHub Actions Test Docker with GitHub Actions Sep 22, 2019
@hugovk hugovk force-pushed the test-docker-with-github-actions branch from 0773d45 to fc4dbf8 Compare October 8, 2019 08:26
@hugovk
Copy link
Member Author

hugovk commented Oct 8, 2019

Okay to merge?

@radarhere radarhere merged commit 7e980d7 into python-pillow:master Oct 9, 2019
@hugovk hugovk deleted the test-docker-with-github-actions branch October 9, 2019 10:36
@hugovk hugovk mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere left review comments

Assignees
No one assigned
Labels
Build Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugovk @radarhere