Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for Docker builds #4212

Closed
hugovk opened this issue Nov 18, 2019 · 0 comments · Fixed by #4316
Closed

Add coverage for Docker builds #4212

hugovk opened this issue Nov 18, 2019 · 0 comments · Fixed by #4316

Comments

@hugovk
Copy link
Member

hugovk commented Nov 18, 2019

For #3606.

We're testing a number of Docker images on Travis CI (env: DOCKER=... in .travis.yml).

We're also testing them on GitHub Actions (.github/workflows/test-docker.yml, added in #4066) and Azure Pipelines (azure-pipelines.yml, #3670).

However, the Travis builds are tested with coverage which is sent to Codecov, but GitHub Actions and Azure Pipelines do not.

To speed up builds, it would be good to enable coverage on GHA or AP so we can stop testing Docker on Travis.

I don't have a strong preference for GHA or AP. We've started using GHA for Linux, macOS and Windows testing, so AP definitely would have more capacity free and would make things faster overall, and with eggs in more baskets. But GHA would mean there's fewer CI systems to maintain, and it feels a bit easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant