Merge pull request #47 from liukun/fix-metric

Fix "ValueError: math domain error" for metric(0)
python-humanize · Aug 8, 2022 · 14fc392 · 14fc392
2 parents dab62bf + b1ee687
commit 14fc392
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/humanize/number.py b/src/humanize/number.py
@@ -508,7 +508,7 @@ def metric(value: float, unit: str = "", precision: int = 3) -> str:
     Returns:
         str:
     """
-    exponent = int(math.floor(math.log10(abs(value))))
+    exponent = int(math.floor(math.log10(abs(value)))) if value != 0 else 0
 
     if exponent >= 27 or exponent < -24:
         return scientific(value, precision - 1) + unit

diff --git a/tests/test_number.py b/tests/test_number.py
@@ -194,6 +194,7 @@ def test_clamp(test_args: list[typing.Any], expected: str) -> None:
 @pytest.mark.parametrize(
     "test_args, expected",
     [
+        ([0], "0.00"),
         ([1, "Hz"], "1.00 Hz"),
         ([1.0, "W"], "1.00 W"),
         ([3, "C"], "3.00 C"),