Fix ABI tag in macOS wheels #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for having a look. Unfortunately, the tags are very much not correct. You've re-introduced the exact problem the comment talked about solving: Most of the wheels lose their |
|
@jamadden any idea why the current one can't be installed in Azure Pipelines with MacOS x86? Poetry throws this; and it works on every other OS: It does seem like there are two MacOS wheels one with cp311-cp311-universal2 and another cp311-universal2-universal2. Not sure if its related to this? |
|
You'll need to look at pip's debug output, because it works fine for me on macOS. Maybe your pip is too old to understand $ uname
Darwin
$ arch -x86_64 /usr/local/bin/python3.11 -c 'import platform; print(platform.machine())'
x86_64
$ arch -x86_64 /usr/local/bin/python3.11 -m venv ./gtest
$ arch -x86_64 ./gtest/bin/python3.11 -c 'import platform; print(platform.machine())'
x86_64
$ arch -x86_64 ./gtest/bin/python3.11 -m pip install --no-cache-dir greenlet
Looking in indexes: https://pypi.org/simple, ...
Collecting greenlet
Downloading greenlet-3.0.0-cp311-cp311-macosx_10_9_universal2.whl (262 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 262.9/262.9 kB 11.2 MB/s eta 0:00:00
Installing collected packages: greenlet
Successfully installed greenlet-3.0.0
$ arch -x86_64 ./gtest/bin/python3.11 -c 'import greenlet; print(greenlet.getcurrent())'
<greenlet.greenlet object at 0x10afc72a0 (otid=0x10afc71f0) current active started main> |
|
@jamadden Thanks for the feedback. So, I think the issue then is that the The problem then is that there's no 3.12 wheel for x86_64, but I don't know if that's expected: $ http https://pypi.org/pypi/greenlet/json | jq '.urls[].filename' | grep universal
"greenlet-3.0.0-cp310-cp310-macosx_10_9_universal2.whl"
"greenlet-3.0.0-cp310-universal2-macosx_11_0_x86_64.whl"
"greenlet-3.0.0-cp311-cp311-macosx_10_9_universal2.whl"
"greenlet-3.0.0-cp311-universal2-macosx_10_9_universal2.whl"
"greenlet-3.0.0-cp312-universal2-macosx_10_9_universal2.whl"
"greenlet-3.0.0-cp37-universal2-macosx_11_0_x86_64.whl"
"greenlet-3.0.0-cp38-cp38-macosx_11_0_universal2.whl"
"greenlet-3.0.0-cp38-universal2-macosx_11_0_x86_64.whl"
"greenlet-3.0.0-cp39-cp39-macosx_10_9_universal2.whl"
"greenlet-3.0.0-cp39-universal2-macosx_11_0_x86_64.whl"
$ http https://pypi.org/pypi/greenlet/json | jq '.urls[].filename' | grep cp312
"greenlet-3.0.0-cp312-cp312-macosx_13_0_arm64.whl"
"greenlet-3.0.0-cp312-cp312-manylinux_2_17_aarch64.manylinux2014_aarch64.whl"
"greenlet-3.0.0-cp312-cp312-manylinux_2_17_ppc64le.manylinux2014_ppc64le.whl"
"greenlet-3.0.0-cp312-cp312-manylinux_2_17_s390x.manylinux2014_s390x.whl"
"greenlet-3.0.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl"
"greenlet-3.0.0-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl"
"greenlet-3.0.0-cp312-cp312-musllinux_1_1_aarch64.whl"
"greenlet-3.0.0-cp312-cp312-musllinux_1_1_x86_64.whl"
"greenlet-3.0.0-cp312-cp312-win_amd64.whl"
"greenlet-3.0.0-cp312-universal2-macosx_10_9_universal2.whl"This also affects the wheel for 3.7 but probably fewer people will notice since it's EOL anyway. Details3.11
|
|
In CI, you have/had: I don't see what this accomplishes. Candidates for the targeted architecture are chosen based on the platform tag, not the ABI tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABI tags look OK now:
Closes #369