Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release wheels for macOS have invalid ABI tag #369

Closed
layday opened this issue Sep 29, 2023 · 8 comments
Closed

Pre-release wheels for macOS have invalid ABI tag #369

layday opened this issue Sep 29, 2023 · 8 comments

Comments

@layday
Copy link

layday commented Sep 29, 2023

The macOS wheels for version 3.0.0rc3 uploaded to PyPI have an invalid ABI tag (universal2), which pip refuses to process. greenlet-3.0.0rc3-cp312-universal2-macosx_10_9_universal2.whl should be greenlet-3.0.0rc3-cp312-cp312-macosx_10_9_universal2.whl, and so on.

@edgarrmondragon
Copy link
Contributor

I think the wheels for 3.0.0 have a similar problem:

- greenlet-3.0.0-cp312-universal2-macosx_10_9_universal2.whl
+ greenlet-3.0.0-cp312-cp312-macosx_10_9_universal2.whl

@layday
Copy link
Author

layday commented Oct 2, 2023

Yes, these wheels are not installable.

@tasansal
Copy link

tasansal commented Oct 2, 2023

Just noticed this in our CI/CD on Azure DevOps.

It installs on Arm64 M1 Max, but on x86 Mac CI/CD, it fails because it can't find the candidate.

This is on production 3.0.0 that went live a few hours ago.

@edgarrmondragon
Copy link
Contributor

I started a PR: #372

@edgarrmondragon
Copy link
Contributor

edgarrmondragon commented Dec 6, 2023

I think the wheel tags were fixed by 4418940 so this can probably be closed

@jamadden
Copy link
Contributor

jamadden commented Dec 8, 2023

Everything looks correct to me in 3.0.2.

@jamadden jamadden closed this as completed Dec 8, 2023
@layday
Copy link
Author

layday commented Dec 13, 2023

The macOS 11.0 tag that is currently in use means that macOS wheels are no longer installable using pip depending on the version of the macOS SDK Python was built against, because the version of packaging that pip bundles is two years out of date and does not emit new-style macOS version tags (see pypa/packaging#497). Upgrading packaging in pip is blocked on legacy version specifier removal (pypa/pip#11715). Please use macosx_10_16_universal2 instead of macosx_11_0_universal2 if the earliest macOS version you support is indeed Big Sur.

@jamadden
Copy link
Contributor

The earliest tested macOS is macOS 12 (Monterey).

@python-greenlet python-greenlet locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants