deprecate hook configuration via marks/attributes #9118

RonnyPfannschmidt · 2021-09-23T07:29:36Z

fixes #4562

must be merged after #8508

src/_pytest/config/__init__.py

Noticed while reviewing pytest-dev/pytest#9118

nicoddemus

Thanks @RonnyPfannschmidt, this issue wasn't even in my radar. 😁

Left some comments, please take a look.

changelog/4562.deprecation.rst

doc/en/deprecations.rst

src/_pytest/config/__init__.py

src/_pytest/deprecated.py

testing/deprecated_test.py

Noticed while reviewing pytest-dev/pytest#9118

bluetech

Left some comments on the docs/texts. I haven't reviewed the code, will try to later.

doc/en/deprecations.rst

src/_pytest/deprecated.py

changelog/4562.deprecation.rst

doc/en/deprecations.rst

nicoddemus

Great work!

RonnyPfannschmidt · 2022-09-22T20:10:36Z

@nicoddemus as far as i can tell, the only blocker is pytest-dev/pytest-cov#549

The old way using marks is being deprecated in pytest 7.2: pytest-dev/pytest#9118

nicoddemus · 2022-09-22T20:26:06Z

That has just been merged. 👍

The-Compiler · 2022-10-06T07:20:05Z

I'm afraid the error messages this generates for hookimpls are almost unusable due to having way too little information where the culprit is: #10342

See pytest-dev/pytest#9118

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers Closes ionelmc#223

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers Closes ionelmc#223

The-Compiler · 2022-10-07T10:12:06Z

Quick analysis of the impact of this:

attributes (seems to be very rare)
marks (rather common!)

FWIW, I submitted PRs to the affected plugins I use:

Follow-up to pytest-dev#9118

RonnyPfannschmidt · 2022-10-07T10:20:03Z

The impact is not surprising, this was intended to be deprecate back when the new decorators came up

Instead the old way was cargo culted all the way till now

See pytest-dev/pytest#9118

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers Closes #223

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

RonnyPfannschmidt added the type: deprecation feature that will be removed in the future label Sep 23, 2021

RonnyPfannschmidt commented Sep 23, 2021

View reviewed changes

src/_pytest/config/__init__.py Outdated Show resolved Hide resolved

RonnyPfannschmidt changed the title ~~deprecate hook configuration via marks/attributes~~ [WIP] deprecate hook configuration via marks/attributes Sep 23, 2021

RonnyPfannschmidt requested a review from nicoddemus September 23, 2021 14:36

nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this pull request Sep 24, 2021

Use modern options configurations for hooks

da606e7

Noticed while reviewing pytest-dev/pytest#9118

nicoddemus mentioned this pull request Sep 24, 2021

Use modern options configurations for hooks pytest-dev/pytest-xdist#708

Merged

nicoddemus requested changes Sep 24, 2021

View reviewed changes

nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this pull request Sep 24, 2021

Use modern options configurations for hooks

a86b90f

Noticed while reviewing pytest-dev/pytest#9118

nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this pull request Sep 24, 2021

Use modern options configurations for hooks

c7c7f9e

Noticed while reviewing pytest-dev/pytest#9118

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from a445d0f to 430ac90 Compare October 1, 2021 19:57

This comment has been minimized.

Sign in to view

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from 430ac90 to 985bd3e Compare October 2, 2021 05:27

bluetech reviewed Oct 2, 2021

View reviewed changes

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from d2e9fd5 to c53e07c Compare October 3, 2021 14:02

nicoddemus reviewed Oct 4, 2021

View reviewed changes

doc/en/deprecations.rst Outdated Show resolved Hide resolved

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from e7d30c9 to df09799 Compare October 10, 2021 14:46

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from df09799 to 34665e7 Compare November 17, 2021 13:39

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from 34665e7 to 825dae2 Compare February 27, 2022 07:30

RonnyPfannschmidt marked this pull request as draft February 27, 2022 07:33

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch 3 times, most recently from 2dabd1b to 38f4561 Compare March 8, 2022 08:51

RonnyPfannschmidt changed the title ~~[WIP] deprecate hook configuration via marks/attributes~~ deprecate hook configuration via marks/attributes Mar 8, 2022

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from 3417054 to ee7c8bf Compare March 8, 2022 09:13

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from ee7c8bf to 92bf2ee Compare May 15, 2022 20:59

RonnyPfannschmidt marked this pull request as ready for review May 15, 2022 21:00

RonnyPfannschmidt added this to the 7.2 milestone Jul 11, 2022

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch 2 times, most recently from 22a9238 to 4052ce6 Compare July 30, 2022 19:59

RonnyPfannschmidt requested a review from nicoddemus July 30, 2022 20:01

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from 83ca2ce to 807e287 Compare September 20, 2022 14:23

RonnyPfannschmidt added 3 commits September 20, 2022 16:24

simplify typing for legacy hook mark support

e329439

unify option extraction for legacy hook marks

7e8a484

add docstring to warn_explicit_for

ae9dbf5

RonnyPfannschmidt force-pushed the fix-4562-deprecate-hookmarkers branch from 807e287 to ae9dbf5 Compare September 20, 2022 14:24

nicoddemus approved these changes Sep 22, 2022

View reviewed changes

ionelmc pushed a commit to pytest-dev/pytest-cov that referenced this pull request Sep 22, 2022

Use modern approach to specify hook options

b077753

The old way using marks is being deprecated in pytest 7.2: pytest-dev/pytest#9118

bump plugin test pytest cov pin

ce3e2e9

RonnyPfannschmidt merged commit 2be1b8f into pytest-dev:main Oct 2, 2022

RonnyPfannschmidt deleted the fix-4562-deprecate-hookmarkers branch October 2, 2022 10:59

This was referenced Oct 6, 2022

Hook configuration via attributes is deprecated in pytest ionelmc/pytest-benchmark#223

Closed

Old-style hookimpl warning has no location information #10342

Closed

The-Compiler added a commit to The-Compiler/pytest-qt that referenced this pull request Oct 6, 2022

Use pytest.hookimpl

5ea1611

See pytest-dev/pytest#9118

The-Compiler mentioned this pull request Oct 6, 2022

Use pytest.hookimpl pytest-dev/pytest-qt#455

Merged

The-Compiler added a commit to The-Compiler/pytest-qt that referenced this pull request Oct 6, 2022

Use pytest.hookimpl

65ab139

See pytest-dev/pytest#9118

The-Compiler added a commit to The-Compiler/pytest-instafail that referenced this pull request Oct 7, 2022

Use pytest.hookimpl to configure hooks

06d6ca4

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

The-Compiler mentioned this pull request Oct 7, 2022

Use pytest.hookimpl to configure hooks pytest-dev/pytest-instafail#26

Merged

The-Compiler mentioned this pull request Oct 7, 2022

Use pytest.hookimpl/.hookspec to configure hooks ionelmc/pytest-benchmark#224

Merged

The-Compiler added a commit to The-Compiler/pytest that referenced this pull request Oct 7, 2022

Mark tryfirst/trylast as deprecated in their docs.

72cac9b

Follow-up to pytest-dev#9118

The-Compiler mentioned this pull request Oct 7, 2022

Mark tryfirst/trylast as deprecated in their docs. #10347

Merged

The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Oct 7, 2022

bleeding tests: Use forks of pytest-benchmark and -instafail

208be25

See pytest-dev/pytest#9118

ionelmc pushed a commit to ionelmc/pytest-benchmark that referenced this pull request Oct 7, 2022

Use pytest.hookimpl/.hookspec to configure hooks

d135104

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers Closes #223

jpvanhal pushed a commit to pytest-dev/pytest-instafail that referenced this pull request Nov 11, 2022

Use pytest.hookimpl to configure hooks

7d997d6

See pytest-dev/pytest#9118 https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deprecate hook configuration via marks/attributes #9118

deprecate hook configuration via marks/attributes #9118

RonnyPfannschmidt commented Sep 23, 2021 •

edited

nicoddemus left a comment

This comment has been minimized.

bluetech left a comment

nicoddemus left a comment

RonnyPfannschmidt commented Sep 22, 2022

nicoddemus commented Sep 22, 2022

The-Compiler commented Oct 6, 2022

The-Compiler commented Oct 7, 2022

RonnyPfannschmidt commented Oct 7, 2022

deprecate hook configuration via marks/attributes #9118

deprecate hook configuration via marks/attributes #9118

Conversation

RonnyPfannschmidt commented Sep 23, 2021 • edited

nicoddemus left a comment

Choose a reason for hiding this comment

This comment has been minimized.

bluetech left a comment

Choose a reason for hiding this comment

nicoddemus left a comment

Choose a reason for hiding this comment

RonnyPfannschmidt commented Sep 22, 2022

nicoddemus commented Sep 22, 2022

The-Compiler commented Oct 6, 2022

The-Compiler commented Oct 7, 2022

RonnyPfannschmidt commented Oct 7, 2022

RonnyPfannschmidt commented Sep 23, 2021 •

edited