Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook configuration via attributes is deprecated in pytest #223

Closed
The-Compiler opened this issue Oct 6, 2022 · 1 comment · Fixed by #224
Closed

Hook configuration via attributes is deprecated in pytest #223

The-Compiler opened this issue Oct 6, 2022 · 1 comment · Fixed by #224

Comments

@The-Compiler
Copy link
Contributor

When running this plugin with pytest main, it complains about

pytest-benchmark/src/pytest_benchmark/hookspec.py

Lines 148 to 152 in 4a99afe

pytest_benchmark_scale_unit.firstresult = True
pytest_benchmark_generate_commit_info.firstresult = True
pytest_benchmark_generate_json.firstresult = True
pytest_benchmark_generate_machine_info.firstresult = True
pytest_benchmark_group_stats.firstresult = True

with:

pytest.PytestDeprecationWarning: The hookspec pytest_benchmark_generate_commit_info uses old-style configuration options (marks or attributes).
Please use the pytest.hookspec(firstresult=True) decorator instead
 to configure the hooks.

See Deprecations and Removals: Configuring hook specs/impls using markers and pytest-dev/pytest#9118.
@The-Compiler
Copy link
Contributor Author

Same also for the pytest_configure hookimpl:

pytest-benchmark/src/pytest_benchmark/plugin.py

Line 437 in 4a99afe

@pytest.mark.trylast # force the other plugins to initialise, fixes issue with capture not being properly initialised

The-Compiler added a commit to The-Compiler/pytest-benchmark that referenced this issue Oct 7, 2022
@The-Compiler
Use pytest.hookimpl/.hookwrapper to configure hooks
b7af774 
See
pytest-dev/pytest#9118
https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

Closes ionelmc#223
The-Compiler added a commit to The-Compiler/pytest-benchmark that referenced this issue Oct 7, 2022
@The-Compiler
Use pytest.hookimpl/.hookspec to configure hooks
665b475 
See
pytest-dev/pytest#9118
https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

Closes ionelmc#223
@The-Compiler The-Compiler mentioned this issue Oct 7, 2022
Merged
ionelmc pushed a commit that referenced this issue Oct 7, 2022
@The-Compiler @ionelmc
Use pytest.hookimpl/.hookspec to configure hooks
d135104 
See
pytest-dev/pytest#9118
https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers

Closes #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pytest.hookimpl/.hookspec to configure hooks The-Compiler/pytest-benchmark
1 participant
@The-Compiler