Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust enum reprs conditional from Python 3.10 to 3.11 #8895

Closed
wants to merge 1 commit into from

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Jul 12, 2021

I don't think a changelog fragment is necessary: It changes tests only, no chnagelog fragment was even in the original commit that introduced the condiitonal.

@hroncok hroncok added the type: selftests a problem in the tests of pytest label Jul 12, 2021
@The-Compiler
Copy link
Member

FWIW I'd prefer a revert of those changes - according to the discussion, there are potentially incompatible changes planned for 3.11, and there will be a PEP written first - so at this point, it seems very speculative to me to already have our tests handle the new format when we have no idea how it'll end up looking like.

@The-Compiler The-Compiler added this to the 7.0 milestone Jul 12, 2021
@hroncok
Copy link
Member Author

hroncok commented Jul 12, 2021

Fine by me ;)

@hroncok
Copy link
Member Author

hroncok commented Jul 12, 2021

Alternative approach (full revert) in #8896

@nicoddemus
Copy link
Member

nicoddemus commented Jul 12, 2021

FWIW I'd prefer a revert of those changes - according to the discussion, there are potentially incompatible changes planned for 3.11, and there will be a PEP written first - so at this point, it seems very speculative to me to already have our tests handle the new format when we have no idea how it'll end up looking like.

Agreed, thanks for pointing that out. I thought the changes would land in 3.11, so why not just adjust the code? But given more discussion will certainly follow, then I agree completely.

@nicoddemus
Copy link
Member

Closing in favor of #8896.

@nicoddemus nicoddemus closed this Jul 12, 2021
@The-Compiler The-Compiler added this to In progress in 7.0 release Jul 12, 2021
@The-Compiler The-Compiler moved this from In progress to Done in 7.0 release Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: selftests a problem in the tests of pytest
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants