Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_enum_class with Python 3.10-beta4 #9443

Merged
merged 1 commit into from Jul 19, 2021
Merged

Conversation

befeleme
Copy link
Contributor

Subject: Fix test_enum_class with Python 3.10-beta4

Feature or Bugfix

  • Bugfix

Detail

The fix was tested during rpm package build in Fedora, which then succeeded.
Because the changes were only postponed, I propose to keep the if/else clause, but removing it entirely is also an option.

Relates

#9442

@hroncok
Copy link
Contributor

hroncok commented Jul 13, 2021

Because the changes were only postponed, I propose to keep the if/else clause, but removing it entirely is also an option.

See this relevant discussion in pytest, where we decided to remove it entirely: pytest-dev/pytest#8895

@tk0miya
Copy link
Member

tk0miya commented Jul 13, 2021

Thanks! I did not notice the change.
+1 for removing it entirely too.

@befeleme
Copy link
Contributor Author

I've changed the code accordingly and tested that it builds in Fedora successfully.

@tk0miya
Copy link
Member

tk0miya commented Jul 14, 2021

Hmm... It seems CI has been broken because 3.10-dev @ deadsnakes is still 3.10.0b2+. I don't know why b4 is not still packaged. Anyway, we need to wait for merging this until upgrading.

@tk0miya tk0miya modified the milestones: 4.1.1, 4.1.2 Jul 14, 2021
@tk0miya tk0miya merged commit 42d9d11 into sphinx-doc:4.1.x Jul 19, 2021
@tk0miya
Copy link
Member

tk0miya commented Jul 19, 2021

Now 3.10-dev @ deadsnakes is updated. So I just merged this. Thank you for your contribution!

@befeleme befeleme deleted the bugfix branch July 26, 2021 07:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants