python: fix empty parametrize() leading to "NotSetType.token" id #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ff8b788 NOTSET was changed to a singleton enum, which ended up unexpectedly triggering a code path in ID generation which checks for `isinstance(Enum)`. Add an explicit case for it, which is not too bad anyway.
bluetech
added
the
needs backport
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Aug 25, 2020
python: fix empty parametrize() leading to "NotSetType.token" id
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Aug 25, 2020
python: fix empty parametrize() leading to "NotSetType.token" id
|
Backport: #7688 |
nicoddemus
added
backported
alexharv074
added a commit
to alexharv074/pytest
that referenced
this pull request
Sep 19, 2021
In pytest-dev#7687 a bugfix was added after NOTSET was changed to a singleton enum, which ended up breaking ID generation when it checked for isinstance(Enum). That change, however, did not update the code path in the same ID generation when used as an idfn function. This adjusts the logic to handle both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7686.
In ff8b788
NOTSETwas changed to a singleton enum, which ended up unexpectedly triggering a code path in ID generation which checks forisinstance(Enum).Add an explicit case for it, which is not too bad anyway.