Refactor change in PR#7687 #9104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pytest-dev#7687 a bugfix was added after NOTSET was changed to a singleton enum, which ended up breaking ID generation when it checked for isinstance(Enum). That change, however, did not update the code path in the same ID generation when used as an idfn function. This adjusts the logic to handle both cases.
|
This PR is raised for discussion as much as a request to merge. As a full disclosure, I did not fully understand what this code I edited is doing, and exactly the nature of the bug I am fixing. Rather, I made an educated guess after seeing what was happening inside the debugger. |
|
Hi @alexharv074, Thanks for the PR. Can you explain why the new code is better? They seem equivalent to me, with the exception that yours has a bit of extra duplication (the |
|
@alexharv074 I think a regression test (fails before your change, passes after) would help, both in understanding the issue and in making sure it won't repeat again. |
|
Closing this PR as it's been inactive for almost two years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7687 a bugfix was added
after NOTSET was changed to a singleton enum, which ended up breaking
ID generation when it checked for isinstance(Enum).
That change, however, did not update the code path in the same ID
generation when used as an idfn function.
This adjusts the logic to handle both cases.