New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warnings: fix missing None in existing hook & add some docs #7288
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,7 +112,12 @@ def catch_warnings_for_item(config, ihook, when, item): | |
|
||
for warning_message in log: | ||
ihook.pytest_warning_captured.call_historic( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we usually update deprecated hooks? Asking for my own knowledge. I wasn't sure when I made the change for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it makes sense to update deprecated hooks if it's a simple bugfix like this. |
||
kwargs=dict(warning_message=warning_message, when=when, item=item) | ||
kwargs=dict( | ||
warning_message=warning_message, | ||
when=when, | ||
item=item, | ||
location=None, | ||
) | ||
) | ||
ihook.pytest_warning_recorded.call_historic( | ||
kwargs=dict( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize we had a deprecation file. Thanks @bluetech