warnings: fix missing None in existing hook & add some docs #7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gnikonorov. Wanted to submit this before we forget about this topic. |
gnikonorov
reviewed
May 31, 2020
| @@ -20,6 +20,17 @@ Below is a complete list of all pytest features which are considered deprecated. | |||
| :ref:`standard warning filters <warnings>`. | |||
|
|
|||
|
|
|||
| The ``pytest_warning_captured`` hook | |||
There was a problem hiding this comment.
I didn't realize we had a deprecation file. Thanks @bluetech
gnikonorov
reviewed
May 31, 2020
| @@ -112,7 +112,12 @@ def catch_warnings_for_item(config, ihook, when, item): | |||
|
|
|||
| for warning_message in log: | |||
| ihook.pytest_warning_captured.call_historic( | |||
There was a problem hiding this comment.
Do we usually update deprecated hooks? Asking for my own knowledge. I wasn't sure when I made the change for pytest_warning_recorded
There was a problem hiding this comment.
I think it makes sense to update deprecated hooks if it's a simple bugfix like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers some loose ends from #7255 and fixes the issue reported later in #4049.