Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6951: allow to write TerminalReporter.writer #6986

Conversation

RonnyPfannschmidt
Copy link
Member

closes #6951

@RonnyPfannschmidt RonnyPfannschmidt merged commit ce42938 into pytest-dev:master Mar 30, 2020
@nicoddemus
Copy link
Member

Should we backport this to 5.3.x?

@RonnyPfannschmidt
Copy link
Member Author

It's not affected

@nicoddemus
Copy link
Member

nicoddemus commented Apr 1, 2020

Oh right my bad, that came out in 5.4.0 👍

@nicoddemus
Copy link
Member

nicoddemus commented Apr 1, 2020

Oh sorry @RonnyPfannschmidt I actually meant to backport to 5.4.x, given that master already contains changes for a 5.5.0 release.

@RonnyPfannschmidt RonnyPfannschmidt added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Apr 2, 2020
@RonnyPfannschmidt RonnyPfannschmidt added this to the 5.4.2 milestone Apr 2, 2020
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Apr 2, 2020
3 tasks
jcfr added a commit to jcfr/word_cloud that referenced this pull request Apr 8, 2020
The version 5.4.0 of pytest introduced a regression preventing pytest-sugar
from working (see [1] and [2])

It has been fixed in pytest (see [3]) and waiting a new release of
pytest is published, this commit updates requirements.

[1] Teemu/pytest-sugar#187
[2] amueller#535 (comment)
[3] pytest-dev/pytest#6986
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this pull request Apr 10, 2020
….writer-writable

fix pytest-dev#6951: allow to write TerminalReporter.writer
RonnyPfannschmidt added a commit that referenced this pull request Apr 10, 2020
…lreporter.writer

backport #6986: writable TerminalWriter.writer for deprecation
@RonnyPfannschmidt RonnyPfannschmidt deleted the fix-6951-tw.writer-writable branch June 6, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest >= 5.4.0 raises INTERNALERROR AttributeError with pytest-sugar installed
2 participants